Open kyuhyongpark opened 1 year ago
@troonmel I was not aware of this. By default, the constant nodes are percolated and removed when the functions are first imported, so the issue never came up. It should be easy enough to add a call to percolate
as the first step of the from_primes
function if we want to address this.
I think the default setting in the import_primes is to not percolate and not remove constants. When set remove_constants=True, it does percolate and remove constants.
I'm wondering why carrying around the constant nodes that are already percolated to the other functions makes such a huge difference in the running time.
Oh, I guess you're right; I had it backwards. I have some guesses about why it might be slow, but I'll have to do some digging. Let me know if you figure it out.
I noticed that the running time for building the succession diagram greatly depends on the initial percolation/deletion of constant nodes. @jcrozum Are you aware of this? I'm pretty sure we won't have this issue in the nfvs-motifs though.
I used the 2017 ABA model, and fixed ABA=1 and percolated it. I also used MPBN update.
One could say that you can always percolate first and remove constants, so this is not a problem. Then at least we should document it so that people do this.
The 2017 ABA model
The code I used.