search

jcrumrine / Dasmoto

Codecademy - Hello CSS - Reviewable Project 1
0 stars 0 forks source link

Concise CSS #3

Open aubreywullschleger opened 6 years ago

aubreywullschleger commented 6 years ago

Great! Good job with your concise CSS. I love your use of the html selector to style the font-family of all elements nested inside the <html> element. This practice helps make your CSS more concise.

https://github.com/jcrumrine/prj-rev-bwfs-dasmoto/blob/master/Dasmoto%20Project/resources/css/index.css#L2-L4

Here, consider adding a group selector for the font-weight: bold; to make your CSS even more concise.

jcrumrine commented 6 years ago

On this one, we are going to have to disagree at this point. I understand what you are saying. For me, since I am new to CSS, I would like to see all modifications for a selector together so I don't have to remember to look in different places to figure out what is really happening.