search

jcrumrine / Dasmoto

Codecademy - Hello CSS - Reviewable Project 1
0 stars 0 forks source link

SUMMARY #5

Open aubreywullschleger opened 7 years ago

aubreywullschleger commented 7 years ago

Grade: Meets expectations

Summary: Good job with this project! I like your consistent nesting, indentation, and spacing in your HTML, your use of locally stored images, your use of the html selector in CSS.

A couple things to work on here would be: 1. using descriptive alt attributes on your <img> elements, 2. using group selectors for repeated styles in your CSS, and 3. using the correct syntax for comments in CSS.

Next, as a stretch goal, I challenge you to research and implement media queries to make your page 100% responsive for all screen widths. This is a challenge I think you are ready for based on your work with this project! Here are a couple resources to get you started: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries and https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

jcrumrine commented 7 years ago

I have uploaded a new index.html and index.css files with the changes as outlined above. I have not worked on the stretch project. ;-)