search

jcrygier / graphql-jpa

JPA Implementation of GraphQL (builds on graphql-java)
MIT License
165 stars 46 forks source link

Use graphql-java 4.2; Move away from deprecated API use #39

Closed timtebeek closed 7 years ago

tazmaniax commented 7 years ago

Hi @jcrygier , there seems to be a bunch of changes at https://github.com/cchiaverini/graphql-jpa and I wonder if it makes sense to merge those changes to here so everyone benefits of combined effort. Maybe suggest a pull request?

cchiaverini commented 7 years ago

The changes in my branch are somewhat fluid right now based upon the needs of my prototype project. While I'm thrilled that people are interested in them, I haven't submitted a pull request back to the main repository because I don't consider them ready for public consumption. There are still outstanding issues regarding the N+1 problem, nested filtering, etc. that should be addressed. I've also been working in a silo, so my changes/needs may conflict with @jcrygier 's vision.

tazmaniax commented 7 years ago

@cchiaverini completely understand and makes sense your approach. Just want to spread awareness and make connections so we can collectively move this project forward. Thanks to @jcrygier for starting it and yourself for spending time evolving it.

tazmaniax commented 7 years ago

@cchiaverini I've also got some changes that I'm not sure about creating a pull request for and it would be good to discuss somewhere. Maybe a Github issue is a good place to start