jcryptool / core

JCrypTool Core Plug-ins
https://www.cryptool.org
Eclipse Public License 1.0
161 stars 43 forks source link

Weekly Build 2019/12/28 not working #159

Closed simlei closed 4 years ago

simlei commented 4 years ago

The current weekly build at https://github.com/jcryptool/core/releases/tag/Weekly-Build--2019-12-28 does not work right. Most importantly, JCT does not start -- due to 7b359061 which I committed. Another issue is b3f9626 which re-introduces the eclipse/2019-12 target platform definitions which were rolled back already due to #156. However, due to the holidays, we did not catch this early enough so that some changes have slipped in as descendants of these commits that are to be rolled back. I won't be able to rebase/cherry pick this today, I am planning to do this tomorrow. My plan is, in that order:

1) roll back jcryptool/core:develop to ffa12ed6a7993a813d64d660717be0a223abc76d 2) cherrypick 2af53a65a937bfb830423be7736f902cf6836b45 (non-colliding properties changes) 3) re-apply 1fc72361eb891f974945c93bf3be79e672d7a1ea (dependent on 2) ) 4) make a new PR based on 3) that resembles fbdb67c32b271cc0a0db3a58e2e7b0bb7a55e540 5) test locally for proper Maven build output 6) release a new weekly build, flag the old one as not working

Hopefully, that will do it.