jcryptool / core

JCrypTool Core Plug-ins
https://www.cryptool.org
Eclipse Public License 1.0
163 stars 43 forks source link

Use fixed version and move away from Adopt #251

Closed geertjanw closed 3 years ago

geertjanw commented 3 years ago

Best to do CI/CD against whatever is the latest version, e.g., 11, as well as a specific fixed version, e.g., 11.0.3. If the build fails and the fixed version is green, while the latest version is red, you will know that the problem is with the latest version and not with your application's code.

Adopt is no more, Temurin and Zulu are the available alternatives, and Zulu has more versions than Temurin, which is brand new while Zulu has been around for years. See also: https://github.com/geertjanw/core/actions

simlei commented 3 years ago

Hi, this looks like a valuable infrastructure improvement. Thanks a lot! I see you don't have a fork of jcryptool/crypto — how did you encounter this project and the github workflow issue if you don't mind me asking?

geertjanw commented 3 years ago

Hi, this looks like a valuable infrastructure improvement. Thanks a lot! I see you don't have a fork of jcryptool/crypto — how did you encounter this project and the github workflow issue if you don't mind me asking?

Fan of bitcoin looking for tools. :-)

geertjanw commented 3 years ago

Hi, this looks like a valuable infrastructure improvement. Thanks a lot! I see you don't have a fork of jcryptool/crypto — how did you encounter this project and the github workflow issue if you don't mind me asking?

Fan of bitcoin looking for tools. :-)

And work at Azul (especially foojay.io) which provides support for both Zulu and Temurin.

simlei commented 3 years ago

Well, thanks a lot :) FYI, there is a bitcoin / blockchain - related feature in our sister project "CrypTool 2" in the works, but not quite there yet.