search

jcryptool / crypto

JCrypTool Crypto Plug-ins
https://www.cryptool.org
Eclipse Public License 1.0
68 stars 39 forks source link

Overhaul of the Divider game #290

Closed tassadarius closed 4 years ago

tassadarius commented 4 years ago 
Most important changes:
    * Improved visuals (current turn, winner)
    * Improved and extended online help
    * Tried to fix typos
    * Computer makes a little pause so users can see what
      he's doing
    * Minor improvements (see individual changes)

See https://github.com/jcryptool/crypto/issues/287#issuecomment-605492896

Overview of PR

Plugin

old

Old Plugin had minor layout issues. Fixed them by vertically centering the elements and centering the "Who's next" box. The current player is shown with more prominent shadow label

new

The new shell() bug was fixed:

old_bug

Some other minor stuff. (see commit messages indivudually)

Online help

Old online help was quite sparse:

old_help

Added extended help which explains more, especially about how Nim games work.

new_help

tassadarius commented 4 years ago

Can be merged!