jcryptool / crypto

JCrypTool Crypto Plug-ins
https://www.cryptool.org
Eclipse Public License 1.0
68 stars 39 forks source link

Make context and regular help behave the same over all plugins #294

Closed simlei closed 4 years ago

simlei commented 4 years ago

The context and online help across all plugins does not work or work the same way across all plugins.

Problems are:

Below is a summary of the plug-ins w.r.t. the above mentioned points which I tested minus the issue with <a ...></a>. Clone this for the rest of the plugins, then fix all at once.

Analysis








Visuals

































...


Template:

- [ ] Homomorphic Encryption, EN
    - `[x]` has context help
    - `[x]` has online help
    - `[ ]` has toolbar button that shows context help
    - `[x]` do online help images scale with page width?
- [ ] Homomorphic Encryption, DE
    - `[x]` has context help
    - `[x]` has online help
    - `[ ]` has toolbar button that shows context help
    - `[x]` do online help images scale with page width?

--------------
simlei commented 4 years ago

Algorithm browser focus w.r.t. context help

If an algorithm, visual etc. registers context help, the algorithm browser loses focus on selection. This causes problems e.g. when using the algorithm browser in "popped out" side window, as it disappears on focus loss. It is hardly ideal in normal view too, as multiple double clicks may be needed to open the desired view.

algobrowser1

simlei commented 4 years ago

Links

External and internal links behavior

It seems that the behavior differs between different domains. This seems to be due to inclusion in iframes of the online help browser and the domain's preference in that regard.

Goal: complete the <positive/negative>-result-for- list. Negative examples are required to test whether our measures cover every case

Link behavior on simple click

Positive examples:

Linux/GTK3

Windows, external link

OS/X, external

Negative examples

Linux/GTK3

Windows

OS/X

Link behavior on context menu -> open in new window

[1] (Linux/GTK3) Peek 2020-04-14 13-49

simlei commented 4 years ago

closing as this is almost fully addressed now. Link behavior is tracked in another issue