search

jcryptool / crypto

JCrypTool Crypto Plug-ins
https://www.cryptool.org
Eclipse Public License 1.0
67 stars 41 forks source link

Replace certain icons in Toolbar with simpler ones #349

Open tassadarius opened 3 years ago

tassadarius commented 3 years ago

Proposal

In my opinion the icons for the keystore and console are overloaded and not clear immediately.

Current status

image

Proposal

I would opt for simpler, more common symbols like this for keystore:

keys

https://www.flaticon.com/free-icon/keys_2825662#

or this for console

command-window

https://www.flaticon.com/free-icon/command-window_656

grthor commented 3 years ago

With the icon for the keystore, I'm concerned that it won't be recognizable at 16x16 pixel size.

I like the icon for the console. It clearly shows that there is a console behind it.

Attributing Icons is no problem. We do this already with the restart Icon. In our about-Page the attributions are listet: https://github.com/jcryptool/core/blob/e42753e4a69cfc31b3b1e6bc92afaa7773a9f3cb/org.jcryptool.core/OSGI-INF/l10n/bundle.properties#L72 Neustart-Ikon by Google from flaticon.com / CC BY 3.0

We have to make sure that we don't use black icons. You can't see them in dark mode.