search

jcs-legacy / company-quickhelp-terminal

Terminal support for `company-quickhelp'.
GNU General Public License v3.0
13 stars 4 forks source link

Move to company-mode org? #3

Open jcs090218 opened 1 year ago

jcs090218 commented 1 year ago

Hi @dgutov!

I am pinging you here to ask for a quick question about moving this package to company-mode org? This package is created due to the package company-quickhelp unwilling to support terminal mode. Now I rarely use this package and I think it would be great if this could live beside [company-quickhelp]() under the same name/owner.

LMKWYT? Thanks!

dgutov commented 1 year ago

Hi!

What do you use now, if you don't mind me asking? auto-complete?

Regarding this package, I think I'd prefer if it came as a PR for company-quickhelp, because it's a bunch of advices anyway, and I don't have the mental bandwidth to check whether a change in the original breaks something here, whenever those happen.

Ideally, it would probably use popon rather than popup since the former has higher odds to enter GNU ELPA, but that's not a hard requirement (someone could do the changeover later anyway).

jcs090218 commented 1 year ago

What do you use now, if you don't mind me asking? auto-complete?

Oh, I still use company-mode but just not with this package anymore!

Regarding this package, I think I'd prefer if it came as a PR for company-quickhelp, because it's a bunch of advices anyway,

I agree, this was my first attempt https://github.com/company-mode/company-quickhelp/issues/99. And the README.md stated

From the README.md

Since this library relies on pos-tip, and I prefer libraries that do one thing well, company-quickhelp will never be extended with optional terminal support.

This is why this package is created separately. Would that still be a case? 😕

Since I am no longer interested in these two packages company-quickhelp and company-quickhelp-terminal, I would prefer not making PRs.

and I don't have the mental bandwidth to check whether a change in the original breaks something here, whenever those happen.

It's okay if you denied it! My intention here is to help this package find a new home so it doesn't live under the name jcs-elpa. Few suggestions are,

Ideally, it would probably use popon rather than popup since the former has higher odds to enter GNU ELPA, but that's not a hard requirement (someone could do the changeover later anyway).

I don't think popup will ever add to GNU ELPA, at least not very soon https://github.com/auto-complete/popup-el/issues/50. I have no objection on this decision. :)

dgutov commented 1 year ago

Oh, I still use company-mode but just not with this package anymore!

Ah cool, I just noticed that you are the person who's keeping auto-complete on life support.

This is why this package is created separately. Would that still be a case? confused

No, I'm happy to revise that position -- AFAIK a significant number of people continue using Emacs in a terminal, so it's not something we should reject. And the amount of code required seems minimal.

Few suggestions are,

You can have me as the collaborator, so I can help if something broke
We can retire this package once company-quickhelp has the terminal support

Both suggestions sound good to me. But you don't want to work on the aforementioned PR?

I don't think popup will ever add to GNU ELPA, at least not very soon https://github.com/auto-complete/popup-el/issues/50.

Yep. And popon's author has stated his intention to go through the assignment sometime in the future.

jcs090218 commented 1 year ago

No, I'm happy to revise that position -- AFAIK a significant number of people continue using Emacs in a terminal, so it's not something we should reject. And the amount of code required seems minimal.

Sounds good! ;)

Both suggestions sound good to me. But you don't want to work on the aforementioned PR?

It's low priority for me at the moment, plus I think it's pretty easy so anyone would like to do the task can open the PR, it doesn't have to be me! :)

Yep. And popon's author has stated his intention to go through the assignment sometime in the future.

I second this, sounds like the way to go!

LMK how you want to forward this?

dgutov commented 1 year ago

I think it's pretty easy so anyone would like to do the task can open the PR, it doesn't have to be me! :)

Sure.

plus I think it's pretty easy so anyone would like to do the task can open the PR, it doesn't have to be me! :)

I'm happy to wait for that to happen by somebody else's hand. Should we keep this issue open until then?