search

jcs / rubywarden

An unofficial, mostly Bitwarden-compatible API server written in Ruby (Sinatra and ActiveRecord)
ISC License
593 stars 49 forks source link

CORS for new Safari Extension #103

Closed universal closed 4 years ago

universal commented 4 years ago

It appears the new bitwarden extension for safari needs some CORS stuff. I'm still figuring things out and need to find my old macbook and have a look.

worth looking into

markfoodyburton commented 4 years ago

Have same problem

universal commented 4 years ago

since my old macbook only has high sierra available I wasn't able to test anything mac specific over the weekend. I might find some time this weekend.

markfoodyburton commented 4 years ago

FWIW I'm stuck on High Sierra too.

raufis27 commented 4 years ago

What we gonna do about this ? "An error has occurred Preflight response is not successful" < Safari extension.

jcs commented 4 years ago

Please try c7c9667 and see if it fixes the Safari extension for you.

universal commented 4 years ago

I deployed this and my brother, who is using a mac / safari, reported that it is working again :-) thanks for the work!

manojchandrashekar commented 4 years ago

I am seeing this again. Also mentioned here: https://github.com/bitwarden/browser/issues/1140

And the code above is already in the latest release. lib/app.rb.