search

jcsaaddupuy / tt-rss-shaarli

Adds support for sharing links with Shaarli to tt-rss
9 stars 6 forks source link

Wrong image path in function hook_article_button at init.php #6

Open future-generation opened 7 years ago

future-generation commented 7 years ago

Instead of return "<img src=\"plugins.local/shaarli/shaarli.png\" it should be return "<img src=\"plugins/shaarli/shaarli.png\"

nodiscc commented 7 years ago

I have the same problem. The commit https://github.com/Luxoboy/tt-rss-shaarli/commit/4d1423ef7bf689db416f8c292b9999d576a33b30 linked by @Luxoboy fixes this.

@jcsaaddupuy are you still maintaining this?

Or maybe @ldidry or @FramaJosephK from @framasoft would be interested in taking over maintenance of this plugin, since they host both public shaarli and tt-rss instances on their servers.

nodiscc commented 7 years ago

I was reminded on another plugin issue tracker that the correct directory to install plugins to is plugins.local. Also see the commit message on https://github.com/jcsaaddupuy/tt-rss-shaarli/commit/3201b88b5573763a07c4858b5c2d1d91be41f6fa

Update to take account the new directory scheme.

External plugins (not provided by tt-rss installation) have to be in plugins.local/ directory, because this one is ignored by git pull / push

So the correct solution is to reinstll the plugin to plugins.local. I don't know where this is documented in tt-rss documentation, but it seems to be the accepted method.