jcsmorais / shortcut-buttons-flatpickr

Flatpickr's plugin that provides users an alternative way to interact with the datetime picker.
MIT License
26 stars 15 forks source link

Shortcut buttons plugin should not use submit buttons #16

Closed tpetry closed 4 years ago

tpetry commented 4 years ago

The Shortcut Buttons plugin creates normal buttons to confirm or delete flatpickr values. However, since the HTML standard interprets buttons as type="submit" by default, the buttons created by the plugin do not serve their actual purpose.

In my case the enter event on completely independent form elements was evaluated differently from what it should be.

jcsmorais commented 4 years ago

Good catch @tpetry, thanks for the contribution 👍

tpetry commented 4 years ago

Could you publish a patch release to npm?

jcsmorais commented 4 years ago

Yes, I'll do it either later today or over the weekend.

tpetry commented 4 years ago

I just wanted to remind you nicely on the npm release ;)

jcsmorais commented 4 years ago

@tpetry done 😉