search

jcsteh / axSGrease

Greasemonkey scripts to improve the accessibility of various websites (e.g. Pandora) and to solve common web accessibility problems (e.g. windowless Flash).
25 stars 17 forks source link

Reordering issues functionality overridden #15

Open LJWatson opened 7 years ago

LJWatson commented 7 years ago

Github has recently introduced the ability to reorder issues under milestones using buttons. When the Greasemonkey/Tampermonkey scripts are enabled, these buttons are not recognised. In Chrome and Firefox with NVDA, there doesn't seem to be any indication that the buttons are present at all. In Firefox with Jaws it's the same, but in chrome the buttons are reported as graphics (with "move up" or "move down" also announced).

derekriemer commented 6 years ago

I can't figure out how to reproduce this, although I swear I saw it a few weeks ago.

jcsteh commented 6 years ago

I think you'll only see this when viewing open issues for an open milestone. The reason is probably that the graphics end up occurring outside of a role="cell", so they are invalid as far as the table structure is concerned. If I'm right, we'd either need to aria-owns them into another cell or create another cell for them. The latter would be better, but is problematic if some rows have them and some don't.

mcking65 commented 6 years ago

It looks like the button for reordering has role cell on it.

jcsteh commented 6 years ago

Oh right. Yeah, I guess that makes sense. That's kinda tricky because the button needs to be within a cell, but it isn't itself a cell. We really don't want to mess with the hierarchy, so I guess we'll need some aria-owns black magic here.