jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Cut off configuration window on small monitor #1027

Open Buy-One opened 5 months ago

Buy-One commented 5 months ago

The max screen resolution is 1366 x 738, Windows 7 x64, REAPER 7.11.

Didn't view it on larger monitor (i'm not blind), so maybe it's not related to the monitor size.

image

jcsteh commented 5 months ago

The core devs are all blind, so we can't see the screenshot, but I'm guessing you mean it's cut off vertically; i.e. not all the options fit in the dialog? That dialog is only going to get more options over time, so I think we ideally need it to be vertically scrollable. Just to double check, is it not already vertically scrollable? I'm not quite sure how to do that in a .rc file though. Hmm.

jcsteh commented 5 months ago

Investigation note: this article might help in making the dialog scrollable

Buy-One commented 5 months ago

It's severely cut off vertically, the last option that's clearly visible is Report MIDI notes in MIDI editor and the dialogue isn't scrollable. It's also somewhat cut off on the right which affects the caption of the option Report position when navigating chords in MIDI editor, the last visible word is edi rather than editor.

But since i'm not using screen reader and not familiar with how it works i don't know if this really is an issue for blind users in case it's able to read text as long as it's there regardless of the text visibility.

jcsteh commented 5 months ago

It's not an issue for users of only speech and braille, but we still want this to appear properly visually, both for sighted testers and also for screen reader users that might have some vision. (Not all screen reader users are totally blind.) So, I do appreciate you reporting this.

How much of your screen isn't being used that could be used both horizontally and vertically? I'm guessing we'd need to make this vertically scrollable in any case, but it seems like the horizontal truncation might just be a matter of the dialog coordinates being a bit wrong.

Buy-One commented 5 months ago

You wrote:

How much of your screen isn't being used that could be used both horizontally and vertically?

Vertically it's 287 px from the top (see response to the next comment below). Horizontally it's 504 px in both directions i suppose because the distance between screen edges and the dialogue seems symmetric.

You wrote:

but it seems like the horizontal truncation might just be a matter of the dialog coordinates being a bit wrong.

Upon opening the dialogue's bottom edge is flush with the bottom taskbar upper edge, so it doesn't open in the middle, unlike it does horizontally.

The last dialogue coordinates aren't stored, unlike for example coordinates of the SWS extension windows.

Buy-One commented 2 months ago

Regarding the Configuration window in the latest build pr1106-1480,6734c5a0

It's not cut off any longer but all because of being huge now taking up about 2/3 of the screen horizontally on the right and the entire screen height vertically. Its right edge is flush with the screen right edge but the bottom goes behind the taskbar. There're lots of dead space to the right of the longest caption and to the bottom of the OK and Cancel buttons.