search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Make adjusting MIDI Editor horizontal zoom report pixels per second instead of pixels per tick #1082

Closed ScottChesworth closed 5 months ago

ScottChesworth commented 5 months ago

The difference between reporting in MIDI Editor and TCP caused some confusion on RWP, @RDMurray said he'd have a go at getting the MIDI Editor reports to be pixels per second.

RDMurray commented 5 months ago

I've figured out what's going on. If vue menu -> piano role time base is project beats (default) or source beats, the zoom ratio is stored as pixels/midi tick, Presumably because they are displayed with a constant number of pixels per beat regardless of project tempo changes. In the case where there are tempo changes reporting in pixels per second would not be accurate. See timebase help... in the same menu for details.

I propose reporting in pixels per beat in this case; it's always accurate and as a bonus easier to code.

I know it's mostly visual, but these options do affect the pixel movement commands.

On a related note, I wonder if we should respect timebase: source beats for position reports. It displays time on the ruler based on the start of the midi source.