search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
128 stars 46 forks source link

Keymap june24 #1127

Closed ScottChesworth closed 4 months ago

ScottChesworth commented 5 months ago

Includes all changes proposed in #1076 for wider testing

AppVeyorBot commented 5 months ago

Build succeeded! Build osara pr1127-1562,11883f6f completed (commit https://github.com/jcsteh/osara/commit/11883f6f0c by @ScottChesworth) Downloads:

Windows - [installer/osara_pr1127-1562,11883f6f.exe](https://ci.appveyor.com/api/buildjobs/3orqokxwq0k4qpod/artifacts/installer/osara_pr1127-1562,11883f6f.exe) - [locale/osara_pr1127-1562,11883f6f.pot](https://ci.appveyor.com/api/buildjobs/3orqokxwq0k4qpod/artifacts/locale/osara_pr1127-1562,11883f6f.pot)
Mac - [installer/osara_pr1127-1562,11883f6f.dmg](https://ci.appveyor.com/api/buildjobs/v5vy9rx2sya8x1fe/artifacts/installer/osara_pr1127-1562,11883f6f.dmg)
AppVeyorBot commented 5 months ago

Build succeeded! Build osara pr1127-1564,9a234b17 completed (commit https://github.com/jcsteh/osara/commit/9a234b175b by @ScottChesworth) Downloads:

Windows - [installer/osara_pr1127-1564,9a234b17.exe](https://ci.appveyor.com/api/buildjobs/y0aaw45yx5ij1y1y/artifacts/installer/osara_pr1127-1564,9a234b17.exe) - [locale/osara_pr1127-1564,9a234b17.pot](https://ci.appveyor.com/api/buildjobs/y0aaw45yx5ij1y1y/artifacts/locale/osara_pr1127-1564,9a234b17.pot)
Mac - [installer/osara_pr1127-1564,9a234b17.dmg](https://ci.appveyor.com/api/buildjobs/80354r6h945eadn4/artifacts/installer/osara_pr1127-1564,9a234b17.dmg)
AppVeyorBot commented 4 months ago

Build succeeded! Build osara pr1127-1567,78d212b4 completed (commit https://github.com/jcsteh/osara/commit/78d212b4ab by @ScottChesworth) Downloads:

Windows - [installer/osara_pr1127-1567,78d212b4.exe](https://ci.appveyor.com/api/buildjobs/twhw4q43sty0g7wk/artifacts/installer/osara_pr1127-1567,78d212b4.exe) - [locale/osara_pr1127-1567,78d212b4.pot](https://ci.appveyor.com/api/buildjobs/twhw4q43sty0g7wk/artifacts/locale/osara_pr1127-1567,78d212b4.pot)
Mac - [installer/osara_pr1127-1567,78d212b4.dmg](https://ci.appveyor.com/api/buildjobs/lrgwyl4qr4rv0h15/artifacts/installer/osara_pr1127-1567,78d212b4.dmg)
jcsteh commented 4 months ago

Minor points for future reference/thought:

  1. I'd really prefer to have the summary of key map changes included in the commit message. Having it separate means we lose track of it in the commit history and it's unclear what changed in a given commit.
  2. For big key map changes, I don't think code changes should be included in the same commit. I think it's fine to include a single key map change in the same commit as a single code change. However, when it's a larger key map commit, again it gets blurry what is changing and why.
ScottChesworth commented 4 months ago

Ah sorry about that, will keep those points in mind next time. I only included code here because I goofed, thought some feedback I implemented in another PR had already been merged. You'd already reviewed the other PR, so the code itself should be up to snuff.

jcsteh commented 4 months ago

Yeah, the code is fine, just purely about organisation and history. It's no biggy, just things for future reference. Thanks.