search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

I don't understand the last translation #1134

Closed reaperaccessible closed 2 months ago

reaperaccessible commented 3 months ago

Here are the strings to translate: {} CC event pixel left {} CC events pixel left This doesn't mean anything, do you want to say this: MIDI CC event moved to left by {} pixel If not, what exactly do you want to state?

{} CC event grid unit left Do you mean: MIDI CC event moved to left by {} grid unit Thanks.

jcsteh commented 3 months ago

There are translator comments for all of these messages describing when they are used. Are they not showing up for you?

MatejGolian commented 3 months ago

@reaperaccessible, you understand it correctly - that's exactly what those strings mean. They are analogous to the strings {} note pixel left, {} notes pixel left and so on that we are already using when moving notes.

MatejGolian commented 3 months ago

Sorry... On second read actually that's not what those messages are meant to say, but like I wrote, they are analogous to the messages reported when moving notes.

Timtam commented 3 months ago

Those messages follow the "most important bit of information first" rule, means that people can continue before the screen reader stopped speaking if the most important information was already spoken. With that being said, the number is obviously the most important information here, so its the very first that gets spoken.

reaperaccessible commented 3 months ago

If I set the MIDI editor to event list mode and use the following 2 actions: Edit: Move CC events left by grid Edit: Move CC events right by grid OSARA should state the number of selected MIDI CC events that were moved either per pixel or per grid division. Is this correct? I installed osara_2024.7.7.1573,dc569dfd and I tested these 2 actions but I have no feedback from OSARA. Is it normal? Thanks.

Timtam commented 3 months ago

I don't know for sure, but i think OSARA only considers CC events as selected when navigated with the OSARA shortcuts, not through the event list. I'd expect the same for notes too TBH. Means that OSARA probably doesn't respect the currently selected events within the event list for keystrokes, since those events aren't notes nor CC events, but MIDI events in general, to be overly precise. I'm pretty sure that Cockos doesn't consider the events selected within the events list as CC events or notes either.

ScottChesworth commented 3 months ago

Those actions don't seem to work in the event list here, OSARA isn't speaking because nothing changes. They do work and report fine in the piano roll, the IDs are the same and so far as I can tell we're not specifying only one section, so I'm not sure why we're seeing this behaviour. Probably need to test without OSARA running to find out whether it's one for Cockos, but I don't have time to do that right now.

reaperaccessible commented 3 months ago

Ok, so I have to stay in Piano Roll mode in the MIDI editor and select the CCs from there? I used the following 2 actions: OSARA: Move to previous CC and add to selection OSARA: Move to next CC and add to selection But nothing is stated with these 2 actions. I don't understand at all the method to use to select MIDI CCs from the MIDI editor in piano roll mode and then move them by grid or pixel. Better yet, the following 2 actions do not work in event list editor mode. Edit: Move CC events left by grid Edit: Move CC events right by grid In event list mode, if I select a MIDI CC and trigger these 2 actions, the MIDI CC does not change position on the grid.

jcsteh commented 2 months ago

These messages only get used if we aren't reporting specific information about the CC that is being moved, which only happens if 2 CCs at different positions are selected or if there are more than 8 CCs selected. To get these messages, you'll need to do something like the following:

  1. Ensure you're running at least REAPER 7.17, as earlier versions have weird bugs with these CC movement actions.
  2. Insert an empty MIDI item.
  3. Edit: Insert CC event at edit cursor in current lane.
  4. Move forward 1 beat.
  5. Edit: Insert CC event at edit cursor in current lane.
  6. Edit: Select all events.
  7. Edit: Move CC events right by grid.
jcsteh commented 2 months ago

The reasons for the messages being why they are has been explained above, along with instructions for how to see them in context. Also, I double checked that the translator comments are definitely being included in the translation template. Therefore, I'm closing this as complete, though I'm happy to keep discussing here as needed to help with understanding these messages in context.