search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Bug: after sliders are used to specify values in the FX window, subsequent alterations made via the equivalent sliders in the FX Parameters dialog are discarded on close, and the text fields in the FX parameters dialog no longer accept input #206

Open ScottChesworth opened 5 years ago

ScottChesworth commented 5 years ago

This bug seems to apply to all Cockos plugins that have sliders in their GUIs except for ReaEQ. I haven't found a third party plugin that's afflicted yet, but only have a slim selection with accessible sliders to test. It might be an issue that Cockos will need to fix, but I can't quite pin down whether it's our sliders or theirs causing the unexpected behaviour, so would appreciate your input.

Here are steps to reproduce. I'm using Reaper X64 5.974 and OSARA 2019.1pre-129,eddf2ffe on Windows 10.

  1. Create a new track, and instantiate an instance of ReaComp.
  2. In the FX window, navigate to the Threshold slider, adjust its value to -5, then dismiss the window.
  3. Open the FX Parameters dialog, adjust the Threshold parameter to -10 using the Threshold slider, then dismiss the dialog.
  4. Reload the FX Parameter dialog, and you should find that the Threshold slider will have reverted back to -5 (the initial value that we specified in step 2 using the native GUI in the FX window).
  5. Go back into the FX window, and you'll find that the adjustment to -10 we just attempted to make hasn't been reflected in the native GUI.
  6. Under these circumstances it is no longer possible to make manual changes using the accompanying edit field in the FX Parameters dialog. For example, try reopening the dialog and inputting 0.0000 into the threshold edit field. When you Shift+Tab to the slider, it will stubbornly retain its value of -5, and if you Tab back to the text field, you'll find that 0.0000 has been discarded and replaced.
  7. For good measure, reload the FX window, and you should find that the attempt to enter 0.0000 in the previous step hasn't been reflected in the native GUI either.

One temporary workaround is to manually retype the value in the edit field that accompanies each slider before leaving the FX window. This is counter-intuitive because those fields appear to be automatically populated, but once done, alterations made using the FX Parameters dialog do seem to be being retained as expected here, and the slider and edit field function in conjunction as expected. So, does that mean it's Cockos' slider that's acting up?

Dunno if this also applies for the Mac folk. I've put word out on WhatsApp that I'm looking for someone to test and will report back ASAP.

ScottChesworth commented 3 years ago

I'm aware this is low priority, but would still be interested in input from @jcsteh or anyone else with deep knowledge to know whether this is an OSARA bug or something that needs a fix from Cockos. Reproduction steps above still hold up in Reaper 6.15.

ScottChesworth commented 3 years ago

Further testing around how sliders in the FX window interact with envelope points have confirmed that this is a Reaper bug, so I'm adjusting labels accordingly.

RDMurray commented 2 years ago

This bug still exists in Reaper 6.53. Is there a forum thread for it already that I can bump?

ScottChesworth commented 2 years ago

Dunno about a forum thread, but I'm chasing Cockos now.