search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Could OSARA provide speech feedback for all length setting and grid-related actions in the MIDI editor? #433

Open Batworx opened 3 years ago

Batworx commented 3 years ago

I know OSARA provides speech feedback for some of these, but it would be nice if this feedback could be provided for all of them. This way, one would know when, for example, changing grid type between dotted, straight, swing and triplet, or when setting grid or length to divisions smaller than a thirty-second.

ScottChesworth commented 3 years ago

Just to clarify so I can gather up a list of relevant actions and IDs, are we already in good shape with the existing feedback @Batworx? If there's stuff you'd like done going from whole down to 32nd notes, let us know specifically what's missing for ya. My thinking is we'll hopefully be able to get the existing feedback fully fleshed out, then just apply that to all grid divisions/note lengths.

LeonarddeR commented 3 years ago 
  Fixing this is as simple as adding entries to POST_COMMAND_MESSAGES in reaper_osara.cpp. Even someone without programming knowledge should be able to to this, assuming the git workflow is somewhat familiar.
Batworx commented 3 years ago

@ScottChesworth, I just ran some tests. It seems that, for both actions starting with "Set length for next inserted note" and "Set grid to..." OSARA only provides feedback for whole, half, quarter, eighth, sixteenth, and thirty-second. All the actions in between don't report anything. This includes those that say "preserving division type" and "preserving grid type," as well as the odd note length (dotted notes, triplets, quintuplets, etc.)