search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Remember the filter string in FX, track and item parameter list #571

Open michaelvogt33 opened 3 years ago

michaelvogt33 commented 3 years ago

The content of the filter text field in the actions and add fx dialog is remembered during the whole reaper session. In the track, item and fx parameter list dialogs osara forgets the entries in the filter text fields. This is true if a parameter list dialog is closed and reopened. Likewise, if the focus is switched to an application other than reaper and back to reaper while the parameter list is open. When switching to another application, open parameter list dialogs are closed.

Is it possible that

jcsteh commented 3 years ago

The content of the filter text field in the actions and add fx dialog is remembered during the whole reaper session.

This isn't the case for me in the Actions dialog. When I close the Actions dialog, the filter is cleared. The filter is remembered in the Add FX dialog though, as you say.

* osara remembers the entries in the filter text field in the track, item and fx parameter list dialogs during the whole reaper session?
  1. As far as OSARA is concerned, these are all the same dialog. Would you want separate filters for each type (track, item, track FX, take FX) or just for the whole dialog?
  2. I worry this might be undesirable for some users and potentially really confusing as well. If a user wasn't aware what was happening, they might wonder why they're suddenly missing many (if not all) their parameters.
* that the parameter list dialogs remain open even when switching to another application (and the focus on the dialog active before switching is ensured after switching back to reaper)?

I can't fix this unfortunately. This was a necessary side effect of passing through function keys, etc. in parameters dialogs. Some REAPER commands can steal focus, and if that happened, you'd have a Parameters dialog open you could never close. There doesn't seem to be a way to differentiate between focus changing because you switched apps vs focus changing because you opened another dialog within the same app.

Lo-lo78 commented 3 years ago

Hi James, could you develop a menu in the filter field. For example: I am in the filter editing field and with down arrow, or with alt + down arrow, you could open a menu of the last 20 searches. It would be great if this happens for Every single plugin. Let me explain: like, I open ReaEQ I enter the FX Parameters Dialog and I find the latest searches for ReaEQ, I open ReaComp and I find in the FX Parameters Dialog the latest searches for ReaComp. So for each plugin you should find a way to store searches related to the specified plugin. I don't know if I made myself understood. Each plugin has its last 20 specific searches. So I'm not going to find Thresh in ReaEQ's latest research.

Greetings!

ScottChesworth commented 3 years ago

For example: I am in the filter editing field and with down arrow, or with alt + down arrow, you could open a menu of the last 20 searches.

How is navigating a menu containing up to 20 items more productive than just re-typing the desired search string?

Lo-lo78 commented 3 years ago

It often happens to always write the same parameter or several parameters; in this way, going into the filter with alt + down arrow with a click you find yourself in the filtered parameters. What do you say?

Lo-lo78 commented 3 years ago

Another example: you have multiple instances of a FabFilter PRO-Q 3 and you have to search for band 3 and you have to enter it many times to edit it, in another track you have to enter band 4 and you do it by switching from one track to another If these searches were in memory you would not have to do alt + f every time write band 3, and then on the second track, enter and write band 4. You may have to adjust a kick or bass in two different tracks, thus switching between the first parameter band 3 FabFilter and the second band 4 FabFilter is faster. Right now you should always write by hand and this can distract listening to kick or bass because you are busy typing the same parameter with your computer keyboard many times. If you think about it it could be very productive Scott, do you like it? Developing this will probably be tricky.

michaelvogt33 commented 3 years ago

If per Reaper session the filter text entry of each FX instance is remembered, this would save a lot of distraction and allow a smoother workflow.

Maybe in the Osara settings an on / off (default off) switch.

(The last 20 filter strings by alt down I take as not really purposeful).

Von: James Teh @.> Gesendet: Dienstag, 5. Oktober 2021 13:45 An: jcsteh/osara @.> Cc: michaelvogt33 @.>; Author @.> Betreff: Re: [jcsteh/osara] Remember the filter string in FX, track and item parameter list (#571)

The content of the filter text field in the actions and add fx dialog is remembered during the whole reaper session.

This isn't the case for me in the Actions dialog. When I close the Actions dialog, the filter is cleared. The filter is remembered in the Add FX dialog though, as you say.

  1. As far as OSARA is concerned, these are all the same dialog. Would you want separate filters for each type (track, item, track FX, take FX) or just for the whole dialog?
  2. I worry this might be undesirable for some users and potentially really confusing as well. If a user wasn't aware what was happening, they might wonder why they're suddenly missing many (if not all) their parameters.

I can't fix this unfortunately. This was a necessary side effect of passing through function keys, etc. in parameters dialogs. Some REAPER commands can steal focus, and if that happened, you'd have a Parameters dialog open you could never close. There doesn't seem to be a way to differentiate between focus changing because you switched apps vs focus changing because you opened another dialog within the same app.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/571#issuecomment-934332605 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRTZ2CBRUOIARSFLDVI2ZLUFLQKFANCNFSM5D2SSBEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AHRTZ2APRJGZHJ2TCMWREBDUFLQKFA5CNFSM5D2SSBE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG6YMRPI.gif

ScottChesworth commented 3 years ago

Another example: you have multiple instances of a FabFilter PRO-Q 3 and you have to search for band 3 and you have to enter it many times to edit it, in another track you have to enter band 4 and you do it by switching from one track to another. If these searches were in memory you would not have to do alt + f every time write band 3, and then on the second track, enter and write band 4. You may have to adjust a kick or bass in two different tracks, thus switching between the first parameter band 3 FabFilter and the second band 4 FabFilter is faster.

So wait, you're asking for previous searches to be retained per plug-in, not per instance of the Parameters dialog? Hmmm, I guess I can just about see how that could be useful, but I don't see it being possible with OSARA's current dialog.

Right now you should always write by hand and this can distract listening to kick or bass because you are busy typing the same parameter with your computer keyboard many times. If you think about it it could be very productive Scott.

Still not as productive in terms of keystrokes as abbreviating your search terms to the minimum necessary characters, for example, typing just "d 3" instead of "band 3" would likely get you to the same place. My suggestion would be to pause your source material when you can't fully focus on it, for whatever reason. Finding the balance between navigational input and speech output alongside the source material is each user's thing to work out. It's impossible to anticipate every scenario people would want in OSARA itself.

jcsteh commented 3 years ago

The fact that we have inconsistent opinions here as to how this could be efficient and/or not cause problems for other users makes me very reluctant to consider it any further. I'll leave this open for further discussion, but at this point, I'm leaning towards a no-go.

michaelvogt33 commented 3 years ago

Yes, remembering the filter string by plugin is more purposeful than by instance.

Von: ScottChesworth @.> Gesendet: Sonntag, 10. Oktober 2021 20:02 An: jcsteh/osara @.> Cc: michaelvogt33 @.>; Author @.> Betreff: Re: [jcsteh/osara] Remember the filter string in FX, track and item parameter list (#571)

Another example: you have multiple instances of a FabFilter PRO-Q 3 and you have to search for band 3 and you have to enter it many times to edit it, in another track you have to enter band 4 and you do it by switching from one track to another. If these searches were in memory you would not have to do alt + f every time write band 3, and then on the second track, enter and write band 4. You may have to adjust a kick or bass in two different tracks, thus switching between the first parameter band 3 FabFilter and the second band 4 FabFilter is faster.

So wait, you're asking for previous searches to be retained per plug-in, not per instance of the Parameters dialog? Hmmm, I guess I can just about see how that could be useful, but I don't see it being possible with OSARA's current dialog.

Right now you should always write by hand and this can distract listening to kick or bass because you are busy typing the same parameter with your computer keyboard many times. If you think about it it could be very productive Scott.

Still not as productive in terms of keystrokes as abbreviating your search terms to the minimum necessary characters, for example, typing just "d 3" instead of "band 3" would likely get you to the same place. My suggestion would be to pause your source material when you can't fully focus on it, for whatever reason. Finding the balance between navigational input and speech output alongside the source material is each user's thing to work out. It's impossible to anticipate every scenario people would want in OSARA itself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/571#issuecomment-939525775 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRTZ2HQSUTDSFKCAW56L7TUGHIKPANCNFSM5D2SSBEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/AHRTZ2GPM4FTXDTZ64ZIQ6LUGHIKPA5CNFSM5D2SSBE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHAAANDY.gif