jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Announce "some bypassed" when arrowing to a track with some bypassed FX #592

Closed ptorpey closed 2 years ago

ptorpey commented 3 years ago

Just a thought about possibly providing more feedback when arrowing to a track where some, but not all, FX are bypassed.

Currently, when arrowing to a track, Osara will announce "bypassed" if the FX on a track are bypassed. However, if only some of the FX on the track are bypassed, Osara simply lists all the FX on the track but does not give the user an indication that any of the FX are bypassed.

Perhaps it would be helpful if, when arrowing to a track where some of the FX are individually bypassed Osara would list the FX as usual and then say something like "some bypassed. Knowing that some FX are bypassed the user could then go into the FX dialog, arrow through the list of FX, and hear which FX are bypassed or not. This would add a minimal amount of speech feedback to give more useful information.

--Pete

ptorpey commented 2 years ago

Just wondering if others had thoughts on this in terms of telling the user if only some of the FX on a track were bypassed as one arrowed through tracks without having to get into the FX dialog.

Currently, when arrowing to a track, Osara will announce "bypassed" if the FX on a track are bypassed. However, if only some of the FX on the track are bypassed, Osara simply lists all the FX on the track but does not give the user an indication that any of the FX are bypassed.

Perhaps it would be helpful if, when arrowing to a track where some of the FX are individually bypassed Osara would list the FX as usual and then say something like "some bypassed. Knowing that some FX are bypassed the user could then go into the FX dialog, arrow through the list of FX, and hear which FX are bypassed or not. This would add a minimal amount of speech feedback to give more useful information.

--Pete

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/592 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJLK4PXKI6HV3K7TXRTULA3SNANCNFSM5HTVBKMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/ADEPTJKJMMPMZQI7SBTUQTLULA3SNA5CNFSM5HTVBKMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PTV6YWA.gif

ScottChesworth commented 2 years ago

It's a tricky one. Generally, we don't do non-specific feedback round these parts because it's difficult to get right. That said, I can think of plenty of times when hearing that "some bypassed" notification would've saved me a ton of time troubleshooting in projects with complex FX chains, particularly when I'm poking through projects that other people have built (mix rescues can be slow work man). Hmmm, nope, I'm not brave enough to commit to a steadfast opinion on this one. Gonna defer to @jcsteh's wider experience.

ptorpey commented 2 years ago

I don’t know how obvious it is to sighted users if only one or more of the FX on a track is bypassed even if the track as a whole is. Just seemed like it would be useful to have that pointed out if it is possible and might save people some effort. Yes, it would be interesting to see how others feel.

--Pete

From: ScottChesworth @.> Sent: Saturday, November 20, 2021 12:55 PM To: jcsteh/osara @.> Cc: ptorpey @.>; Author @.> Subject: Re: [jcsteh/osara] Announce "some bypassed" when arrowing to a track with some bypassed FX (Issue #592)

It's a tricky one. Generally, we don't do non-specific feedback round these parts because it's difficult to get right. That said, I can think of plenty of times when hearing that "some bypassed" notification would've saved me a ton of time troubleshooting in projects with complex FX chains, particularly when I'm poking through projects that other people have built (mix rescues can be slow work man). Hmmm, nope, I'm not brave enough to commit to a steadfast opinion on this one. Gonna defer to @jcsteh https://github.com/jcsteh 's wider experience.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/592#issuecomment-974703154 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJM5H5STRTIHPAK26RLUM74IHANCNFSM5HTVBKMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

jcsteh commented 2 years ago

Given that the reporting of FX is already pretty verbose and configurable, would it be reasonable to just report "bypassed" after individual effect names if they're bypassed?

ptorpey commented 2 years ago

Interesting point. I was thinking of minimizing speech, but as you say, each FX on the track is already spoken so perhaps just adding the word “bypassed” to any FX that was bypassed wouldn’t be adding much speech. Perhaps that is the easy and more useful solution. In fact, if we just said ‘some bypassed” as I first suggested, the user would have to take the additional steps of opening up the FX dialog and then arrowing through each FX to see which FX were bypassed, and that isn’t very efficient.

I like your idea.

--Pete

From: James Teh @.> Sent: Sunday, November 21, 2021 10:12 AM To: jcsteh/osara @.> Cc: ptorpey @.>; Author @.> Subject: Re: [jcsteh/osara] Announce "some bypassed" when arrowing to a track with some bypassed FX (Issue #592)

Given that the reporting of FX is already pretty verbose and configurable, would it be reasonable to just report "bypassed" after individual effect names if they're bypassed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/592#issuecomment-974857039 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJOFXSY3AMUGDWBZVMDUNER5FANCNFSM5HTVBKMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

ScottChesworth commented 2 years ago

would it be reasonable to just report "bypassed" after individual effect?

That'd work for me.

While this is being refined, any thoughts on silencing the plug-in type and developer to make that report less verbose? IE, when moving to a track with 3 plug-ins instantiated, instead of: 1 Guitar Riff 1 item; FX: VST: ReaEQ (Cockos), VST3: Ultimate Serious Pro (Waves), JS: Soft Clipper/Limiter we'd hear something like: 1 Guitar Riff 1 item; FX: ReaEQ, Ultimate Serious Pro bypassed, Soft Clipper/Limiter

jcsteh commented 2 years ago

That seems like sensible UX, but it should be dealt with in a separate GitHub issue. I'm not sure about technical feasibility though. We get the plugin name as a single string from REAPER, just as you see it there. That means we'd have to split the string based on punctuation and spacing. Is that format ("type: name (vendor)" consistent across configurations and language translations? That would need some investigation.

ScottChesworth commented 2 years ago

That seems like sensible UX, but it should be dealt with in a separate GitHub issue.

Oki doke, just opened #608

ScottChesworth commented 2 years ago

Oh, and GitHub already linked to it. Damn this internet thingy is clever. :)