search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

Add feedback for copy item action #654

Open ptorpey opened 2 years ago

ptorpey commented 2 years ago

Add speech feedback for: "Item: Copy selected area of items"? to be consistent with feedback for other copy/cut/paste functions.

--Pete

RDMurray commented 2 years ago

Fixed in #653

RDMurray commented 2 years ago

oops, sorry must have been half asleep. This is of course not fixed yet.

RDMurray commented 2 years ago

Figuring out exactly what Reaper copies, especially with envelope points and envelope items is turning out to be a bit tricky. Combined with the fact that the method of comparing item counts before and after cut is still causing issues when wripple is set to all, I think we should ask Cockos for an API to inspect the clipboard. Just a count for each type of object in the clipboard would be sufficient. Some way of telling if the clipboard was updated by the last action would also be good so that we can handle the case where nothing is copied. @ScottChesworth could you ask Justin?

jcsteh commented 2 years ago

Sorry; hit submit prematurely.

Note that Even a sighted user can't see what is copied; they make that determination entirely based on what's selected.

Can you elaborate regarding the issues with envelope points and automation items?

For cut, my intention was to tell the user how many items were removed because that's the visible change that happens to the project. However, when splits occur, it obviously ends up adding items, which is the problem we have here. Perhaps we should just report the selected count even for cut. But even if we do that (or we have a clipboard API), what we're reporting is still not really accurate; the user isn't aware that splits have occurred.

I think we should pause here and figure out what problem we're trying to solve and how we'll solve it before pushing for a new API.

RDMurray commented 2 years ago

Okay, fare enough. I was just having trouble understanding how automation items work, because the last point in an item appears at the start of the project and it is reported as unselected. This shouldn't get in the way of implementing feedback for copy though.

As for cut causing splits due to ripple, I don't know what the feedback should be. It could say something about x items split due to ripple or something. I know sighted users don't see exactly what was cut either, but the rippling is probably very obvious.