search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
120 stars 45 forks source link

Better feedback for "turn Recordd Monitor on for all tracks" #692

Closed ptorpey closed 1 week ago

ptorpey commented 2 years ago

In the latest Osara snapshot "turn Record Monitor off for all tracks" , the speech feedback outputs "N tracks selected", where N is the number of tracks in the project.

perhaps a more informative message from Osara would be "record monitor turned off for all tracks".

--Pete

ScottChesworth commented 2 years ago

We're using custom actions to reset monitor and phase globally. Both work reliably but neither provide good feedback, and there's no way around that other than making proper actions. I made a start on replacing a handful of the custom actions we're using a while back alongside implementing the OSARA go to first and last track actions we have now, then I lost a bunch of local code because I'm still an idiot with Git, through a strop and never went back to it. I'll try to get back to where I was, it's not actually difficult really, just a bit beyond what I'm confident with. Can't really promise it'll be soon though, because although what we have right now isn't ideal in terms of feedback, it does work reliably.

ptorpey commented 2 years ago

No problem. It just struck me as kind of curious. Interestingly, the F12 help feedback does give a good description of what the hotkey does. I always thought that the string in the help feedback was the same string that would be spoken by Osara when taking the action. Guess not.

Thanks for the explanation.

--Pete

From: ScottChesworth @.> Sent: Friday, February 25, 2022 12:00 AM To: jcsteh/osara @.> Cc: ptorpey @.>; Author @.> Subject: Re: [jcsteh/osara] Better feedback for "turn Recordd Monitor on for all tracks" (Issue #692)

We're using custom actions to reset monitor and phase globally. Both work reliably but neither provide good feedback, and there's no way around that other than making proper actions. I made a start on replacing a handful of the custom actions we're using a while back alongside implementing the OSARA go to first and last track actions we have now, then I lost a bunch of local code because I'm still an idiot with Git, through a strop and never went back to it. I'll try to get back to where I was, it's not actually difficult really, just a bit beyond what I'm confident with. Can't really promise it'll be soon though, because although what we have right now isn't ideal in terms of feedback, it does work reliably.

— Reply to this email directly, view it on GitHub https://github.com/jcsteh/osara/issues/692#issuecomment-1050579490 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEPTJM7NG62ZO7S2AOE4ATU44SG7ANCNFSM5PJBSPPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . You are receiving this because you authored the thread.Message ID: @.***>

jcsteh commented 1 week ago

This was fixed with a new OSARA action in #971. The OSARA key map was updated to replace the custom action with this new action in #973.