jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
127 stars 46 forks source link

MIDI Editor: broken the chords preview moving throughby #897

Open outsidepro-arts opened 1 year ago

outsidepro-arts commented 1 year ago

I've just skipped some OSARA versions and updated to 2023.1pre-1139,6c64a384 and noticed that when I am moving throughby chords they aren't previewing. I am using the following action in MIDI editor:

May I missed something in configuration?..

ScottChesworth commented 1 year ago

Hmm, there's no config option to silence previews. Do you have a virtual instrument on the track? That would be needed for the previews to be heard.

outsidepro-arts commented 1 year ago

Yep, there an instrument is inserted. And another one thing: I've noticed that if there's one note, it still previews correctly but if there're more than one, OSARA even doesn't report these.

ScottChesworth commented 1 year ago

Does it stay the same even if you switch to a different virtual instrument? Not sure what's happening there man, I've just tested the latest snapshot here and previews/reporting all seem to be working as expected.

outsidepro-arts commented 1 year ago

I will test it at closest time when keep working on current project and report additional details.

outsidepro-arts commented 1 year ago

So, I've tested it more careful.

Based on what I wrote above I have a proposion: we may create a state variable for store the chord navigation and when we're moving through the chords, we may check the state and if this is "true" we do nothing the navigation. Else we selecting the chord. After this condition we set "true" there. When we're starting navigate through the chord's notes, we may set the state to "false".

ScottChesworth commented 1 year ago

Oh, I understand. When there's a single chord and it's at the exact same time as the start of the item, we don't hear a preview or a report, I guess because the cursor isn't moving to make that selection.