search

jcubic / jquery.terminal

jQuery Terminal Emulator - JavaScript library for creating web-based terminals with custom commands
https://terminal.jcubic.pl
MIT License
3.12k stars 569 forks source link

altgr+key on keyboards without #288

Closed jarv closed 7 years ago

jarv commented 7 years ago

After upgrading to version 1.0.5 on cmdchallenge.com multiple people are reporting that altgr+key is not working on non-us layouts. Can you think of any changes in this version that would cause this issue?

jcubic commented 7 years ago

fixed in 1.0.6

Lilja commented 7 years ago

I am here from the cmdchallenge and I don't think this fix fixes it, at least for my pok3r RGB with nordic layout.

You posted a codepen in jarv/cmdchallenge#118 and i modified it.

I can't press <alt+gr>+<+> which produces a \ . 

Keydown Keycode 17 AltKey false CtrlKey true key Control
Keydown Keycode 18 AltKey true CtrlKey true key AltGraph
Keydown Keycode 187 AltKey true CtrlKey true key \
Keypress Keycode 92 AltKey true CtrlKey true key \
jcubic commented 7 years ago

@Lilja what browser/OS you see this? Also what exactly is your keyboard setup? so I can recreate it?

Lilja commented 7 years ago

Win 7/chrome 60.0. 3112.90

Swedish keyboard layout

jcubic commented 7 years ago

Ok it now work, you can test. This regresion was for all layouts that use alt to enter keys with altGr.

jarv commented 7 years ago

@jcubic wow that was fast, I will update the site soon with this new version. thanks!

Lilja commented 7 years ago

Works!