jcuda / jcuda-main

Summarizes the main JCuda libraries
MIT License
99 stars 20 forks source link

Attach sources for native libraries in Maven build #15

Closed jcuda closed 7 years ago

jcuda commented 7 years ago

Maven Central requires the -sources JAR to be present. For the -natives artifacts (that contain the native libraries), these JARs are not yet created.

The build process (i.e. the POMs of the -natives atrifacts) should be updated so that the -sources JARs are generated from the native source directories.

As a short term solution for https://github.com/jcuda/jcuda-main/issues/14 and the initial release in Maven Central, these may be empty JARs.

(The actual usefulness of these JARs may not be so high: They can hardly include the whole source code, e.g. the source code of the jcuda-common project and the CMake files. These would have to go into some (otherwise useless) parent artifact. In general, Maven does not map so well to native projects anyhow).

jcuda commented 7 years ago

The sources are now packed into -sources JARs for the -natives projects, as part of the build process updates for https://github.com/jcuda/jcuda-main/issues/14#issuecomment-282355512

This is done as in https://github.com/jcuda/jcuda/commit/14ac1fb17a016f025be2d3a3f607904056f7de0e#diff-600376dffeb79835ede4a0b285078036R59 (and analogously for all other libraries).

Eventually, the only thing that will not be part of any sources artifact in Maven Central will be the POM and CMake file from here (jcuda-main) - but these are both only combining the Maven module POMs and CMake files from all other projects, so this should be OK.