jcupitt / vipsdisp

Tiny libvips / gtk+4 image viewer
MIT License
143 stars 11 forks source link

imagewindow: Avoid use of GtkFileChooser* when GTK >= 4.10 #25

Closed kleisauke closed 1 year ago

kleisauke commented 1 year ago

The GtkFileChooser APIs are deprecated in favor of the new GtkFileDialog API.

jcupitt commented 1 year ago

I agree getting a native file chooser is nice, but the linux UI for file dialog that comes with 4.10 is VERY basic and I don't think anyone would want to use it. Maybe we should only use file dialog on Windows?

jcupitt commented 1 year ago

o wai, perhaps I'm confused? I tried building this and it seems OK.

Maybe it was just terrible in pre-4.10 gtk?

kleisauke commented 1 year ago

Ah, you're right, it now also appears to open Nautilus instead of the basic one provided by GTK, at least on Fedora 38.

jcupitt commented 1 year ago

I agree, let's use the new thing.

jcupitt commented 1 year ago

(and thanks!)