jcupitt / vipsdisp

Tiny libvips / gtk+4 image viewer
MIT License
130 stars 10 forks source link

Fix build after libvips/libvips#4004 #32

Closed kleisauke closed 1 month ago

kleisauke commented 1 month ago

The deprecated string functions were moved to the deprecated/ directory, which implicitly means you'll need to include vips/vips7compat.h to use them.

Details ``` [1/3] Compiling C object src/vipsdisp.p/gtkutil.c.o FAILED: src/vipsdisp.p/gtkutil.c.o gcc -Isrc/vipsdisp.p -Isrc -I../src -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/Imath -I/usr/include/cfitsio -I/usr/include/webp -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -I/usr/include/libxml2 -I/usr/include/pixman-1 -I/usr/include/fribidi -I/usr/include/librsvg-2.0 -I/usr/include/libpng16 -I/usr/include/OpenEXR -I/usr/include/openjpeg-2.5 -I/usr/include/nifti -I/usr/include/gtk-4.0 -I/usr/include/graphene-1.0 -I/usr/lib64/graphene-1.0/include -I. -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11 -O3 -DHAVE_CONFIG_H -O3 -mfpmath=sse -msse -msse2 -pthread -DHWY_SHARED_DEFINE -DWITH_GZFILEOP -MD -MQ src/vipsdisp.p/gtkutil.c.o -MF src/vipsdisp.p/gtkutil.c.o.d -o src/vipsdisp.p/gtkutil.c.o -c ../src/gtkutil.c ../src/gtkutil.c: In function ‘set_gentryv’: ../src/gtkutil.c:21:16: error: implicit declaration of function ‘vips_vsnprintf’; did you mean ‘g_vsnprintf’? [-Wimplicit-function-declaration] 21 | (void) vips_vsnprintf(buf, 1000, fmt, ap); | ^~~~~~~~~~~~~~ | g_vsnprintf [2/3] Compiling C object src/vipsdisp.p/tilesource.c.o FAILED: src/vipsdisp.p/tilesource.c.o gcc -Isrc/vipsdisp.p -Isrc -I../src -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/Imath -I/usr/include/cfitsio -I/usr/include/webp -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -I/usr/include/libxml2 -I/usr/include/pixman-1 -I/usr/include/fribidi -I/usr/include/librsvg-2.0 -I/usr/include/libpng16 -I/usr/include/OpenEXR -I/usr/include/openjpeg-2.5 -I/usr/include/nifti -I/usr/include/gtk-4.0 -I/usr/include/graphene-1.0 -I/usr/lib64/graphene-1.0/include -I. -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11 -O3 -DHAVE_CONFIG_H -O3 -mfpmath=sse -msse -msse2 -pthread -DHWY_SHARED_DEFINE -DWITH_GZFILEOP -MD -MQ src/vipsdisp.p/tilesource.c.o -MF src/vipsdisp.p/tilesource.c.o.d -o src/vipsdisp.p/tilesource.c.o -c ../src/tilesource.c ../src/tilesource.c: In function ‘tilesource_new_from_file’: ../src/tilesource.c:1553:25: error: implicit declaration of function ‘vips_snprintf’; did you mean ‘vips_shrinkv’? [-Wimplicit-function-declaration] 1553 | vips_snprintf(name, 256, "openslide.level[%d].width", level); | ^~~~~~~~~~~~~ | vips_shrinkv ninja: build stopped: subcommand failed. ```
jcupitt commented 1 month ago

Let's swap to g_vsnprintf() and g_snprintf(), I'll make a patch.

jcupitt commented 1 month ago

Oh wai, that's what you did heh. Thanks!