search

jcurl / RJCP.DLL.SerialPortStream

SerialPortStream is an independent implementation of System.IO.Ports.SerialPort and SerialStream for better reliability and maintainability. Default branch is 2.x and now has support for Mono with help of a C library.
Microsoft Public License
614 stars 196 forks source link

NuGet Dependencies #105

Closed jcurl closed 4 years ago

jcurl commented 4 years ago

Raised by https://github.com/romerod in ticket https://github.com/jcurl/SerialPortStream/issues/104.

The nuget package shows depencendencies for 4.6.2.

The empty group "<group targetFramework=".NETFramework4.6.2" />" is missing.

2.2.0 package:

<dependencies>
      <group targetFramework=".NETFramework4.6.2" />
      <group targetFramework=".NETStandard1.5">
        <dependency id="System.Threading.Overlapped" version="4.3.0" />
        <dependency id="System.Threading.Thread" version="4.3.0" />

2.2.1 package:

<dependencies>
      <group targetFramework=".NETStandard1.5">
        <dependency id="System.Threading.Overlapped" version="4.3.0" />
        <dependency id="System.Threading.Thread" version="4.3.0" />
jcurl commented 4 years ago

The sources for label 2.2.0 and 2.2.1 don't contain the empty group for .NET 4.6.2. This must have been automatically added somewhere.

I downloaded the version from the "assets" for the release here in GitHub, and it doesn't contain the empty group either.

What's the side effect of the missing 4.6.2? Does it pull in unexpected dependencies? If so, I should do a rerelease, in which case I'll open a new ticket, so I can reference it in the commit history.

Retested with NuGet 5.11 and it didn't add the empty 4.6.2 dependency either (but complained there was a missing net40 and net45 dependency, see below). At least I should probably fix that (there are no dependencies that I'm aware of).

WARNING: NU5125: The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
WARNING: NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
- Add a dependency group for .NETFramework4.0 to the nuspec
- Add a dependency group for .NETFramework4.5 to the nuspec
jcurl commented 4 years ago

I've uploaded here the generated packages for testing. serialportstream.zip