search

jcurl / RJCP.DLL.SerialPortStream

SerialPortStream is an independent implementation of System.IO.Ports.SerialPort and SerialStream for better reliability and maintainability. Default branch is 2.x and now has support for Mono with help of a C library.
Microsoft Public License
639 stars 199 forks source link

Fixed project.json wrong compile paths #18

Closed fdipuma closed 7 years ago

fdipuma commented 7 years ago

Adding this library via NuGet to a .NET Core / .NET Standard project result in an empty assembly (without any of the project classes).

This is caused by wrong import paths in the project.json file:

"../code/*.cs",

Relative to the project.json path "../code folder does not exist.

Removed the /code part in the pull request.

jcurl commented 7 years ago

have you looked at the official nuget package? I downloaded the official version and the folder with netstandard15 contains a PDB, DLL and XML file.

fdipuma commented 7 years ago

Yes I have. The assembly (.dll) contains only EntryPointNotFoundException and SerialPort classes. You can verify it by using any assembly disassembler/explorer (dotPeek/ILSpy). Also you may notice that the assembly does not contain any of the other classes because the dll file is just 5kB and the .xml file contains references to only those classes I mentioned earlier.

dotpeek

jcurl commented 7 years ago

This is now merged in 2.1.1. I've just pushed package version 2.1.1 to NuGet if you'd like to test.