search

jcurl / RJCP.DLL.SerialPortStream

SerialPortStream is an independent implementation of System.IO.Ports.SerialPort and SerialStream for better reliability and maintainability. Default branch is 2.x and now has support for Mono with help of a C library.
Microsoft Public License
624 stars 197 forks source link

Missing SerialPortStream project in unit test projects #86

Closed ToddMOsborne closed 5 years ago

ToddMOsborne commented 5 years ago

When I was compiling your main solution file, the unit tests failed to build before a project reference was not added to the main SerialPortStream assembly. I updated this and all is well. I also created .net 4.7.1 versions of all projects and solutions. Let me know if you are interested in having them. Thanks, works great so far!

jcurl commented 5 years ago

Which solution file are you referring to? The SerialPortStream-net40.sln and SerialPortStream-net45.sln work for me, when opening with VS2015. The SerialPortStream-netstandard15 loads with VS2017 and doesn't reference test cases (I don't have the time to support .NET Core, nor Mac).

jcurl commented 5 years ago

Also, for 4.7.1, any functional changes, or just reference updates? In which case, if there are no functional changes, I prefer to support the lowest available standard, as they can then be used by any newer version of .NET allowing the greatest possible deployment.

ToddMOsborne commented 5 years ago

I started by opening the SerialPortStream-net45.sln which include the projects SerialPortStreamTest-net45 and DatastructuresTest-net45. One or both of them did not have a project reference to SerialPortStream-net45, so I added them. They would not compile as is because of the missing reference. No functional changes for 4.7.1, just updated the project files. Thanks,

Todd

On Tue, Feb 26, 2019 at 3:20 PM Jason Curl notifications@github.com wrote:

Also, for 4.7.1, any functional changes, or just reference updates? In which case, if there are no functional changes, I prefer to support the lowest available standard, as they can then be used by any newer version of .NET allowing the greatest possible deployment.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jcurl/SerialPortStream/issues/86#issuecomment-467597828, or mute the thread https://github.com/notifications/unsubscribe-auth/ASxwzCE_NYIhxDqQ99BIy26fMvlT2xDsks5vRZcngaJpZM4bSrb3 .

-- Todd Osborne toddosborne@gmail.com

jcurl commented 5 years ago

I'm not able to reproduce the issue when I check out the files on my system. I don't know what is different from yours.

For now, I need to keep with .NET 4.0 as that is what I need, and there is nothing needed to require .NET 4.7.1 (with .NET 4.5 already provided, it is using whatever version of .NET you've got installed).