search

jcustenborder / kafka-connect-solr

Kafka Connect connector for writing to Solr.
Apache License 2.0
44 stars 28 forks source link

Added configuration parameters for solr connect timeout, solr socket… #41

Closed ramyogi closed 4 years ago

ramyogi commented 4 years ago

… timeout Fixes #40

jcustenborder commented 4 years ago

@ramyogi Where did those defaults come from? Other than that it looks good to me.

ramyogi7283 commented 4 years ago

@jcustenborder I referred Default value from public abstract class SolrClientBuilder<B extends SolrClientBuilder> {

protected HttpClient httpClient; protected ResponseParser responseParser; protected Integer connectionTimeoutMillis = 15000; protected Integer socketTimeoutMillis = 120000;

jcustenborder commented 4 years ago

@ramyogi Thanks for the PR! Your changes have been merged to master. It's also out on the Confluent hub.

confluent-hub install jcustenborder/kafka-connect-solr:0.1.35

ramyogi7283 commented 4 years ago

Amazing @jcustenborder . Thanks a lot for your time to review and approve.