search

jcutler / Missing-E

Missing e is a set of tools, features and interface changes for Tumblr.
67 stars 16 forks source link

Add blockNotes option to Missing-E #30

Open FugiTech opened 12 years ago

FugiTech commented 12 years ago

Allows users to block Like or Reblog notifications on their dashboard on a post by post basis. Has not been tested on Safari as I couldn't figure out how to build the extension without the dev key. Also doesn't have a proper icon for the options page.

jcutler commented 12 years ago

I haven't had a chance to try it out yet, but I'm not 100% sure about the usefulness of such a feature.

First, how would we go about removing things from the block list well after they are no longer needed or wanted? There is an upper bound on the length of the setting that stores that information. Also, hiding them won't make others appear that wouldn't have otherwise shown up, so the benefit of hiding some is fairly small. The notifications never seem to fill a whole page.

I try not to hide content using Missing e, since that was one of the things that got me in hot water with Tumblr staff. It may not be as big a deal with post notifications, but who knows?

After taking a quick look at your code, it does appear to be missing an AJAX handler for notifications that are loaded after the initial page load with endless scrolling (I believe there is an internal API called extension.addAjaxListener that helps with that). I try to steer away from adding too many ajax listeners, since that would slow down responsiveness when loading a secondary dash page.

What do you think?

FugiTech commented 12 years ago

Unblocking is done through the options page. At the bottom of the page is a table with all the users blocked notes, and an unblock button. The maximum length is something I did not account for, but I will look into it. Unfortunately, I don't know an easy way to load additional items, so you are right that this will result in less information on the screen. But I can confirm that there is an AJAX listener at the bottom of the run() function in blockNotes.js, so it will work with endless scrolling.

The point of this addition is for people who's post is reblogged by a "celebrity" (or who are a celebrity themselves), and get a flood of hundreds or thousands of likes, flooding their dashboard. Though, if getting 10 likes on a post irritates somebody, they could benefit as well.

hackedy commented 11 years ago

You can do this with the Tumblr Hate extension, which is available for chrome and maybe safari. It does not have Firefox support. This is something that people do use but it already exists at lightquake/tumblr-hate