search

jd-alexander / Google-Directions-Android

This project allows you to calculate the route between two locations and displays it on a map.
https://play.google.com/store/apps/details?id=com.directions.sample
MIT License
979 stars 394 forks source link

Added ability to use a key for the API request #40

Closed mkiehl closed 8 years ago

mkiehl commented 8 years ago

The commit adds the possibility for users to specify their own API key when accessing the Google Directions API, thus enabling more advanced features such as higher quotas and more waypoints.

To do so the API request must use SSL so the default API URL has been changed to use SSL instead of plain HTTP.

jd-alexander commented 8 years ago

Okay thanks for your contribution. Will push an update to maven later today.

fcduarte commented 8 years ago

@mkiehl which type of key did you use? Android, Server or Browser? I was going to open a pull request with the same feature but I wasn't able to make it work with any of those keys ..

So I'm really curious to know how did you manage to make this thing happen.

Thanks,

fcduarte commented 8 years ago

And if it's working it's worth to mention it on the README @jd-alexander

jd-alexander commented 8 years ago

Yes. I am going to test it. Just haven't gotten around to doing so due to being swamped with projects. I should have tested that branch before merging to main but it's just an extra url parameter so it's not something that will break the library as I looked on the code to be sure of that but still should be tested. On Jan 6, 2016 12:59 PM, "Felipe Duarte" notifications@github.com wrote:

And if it's working it's worth to mention it on the README @jd-alexander https://github.com/jd-alexander

— Reply to this email directly or view it on GitHub https://github.com/jd-alexander/Google-Directions-Android/pull/40#issuecomment-169404734 .

fcduarte commented 8 years ago

I mean, it's a cool feature to have. I just want to make sure that all developers are aware on how to do it :smiley:

jd-alexander commented 8 years ago

Yes very true @fcduarte . I should be dedicating more time to maintaining this but I noticed other developers rewrote it with more modern libraries and such so I just started creting other libs so it's hard to maintain so many with the little time I have.