search

jd-boyd / python-lzo

Python bindings for the LZO data compression library
GNU General Public License v2.0
74 stars 41 forks source link

Limit 2gb on 32 bit #50

Closed Rosuav closed 3 years ago

Rosuav commented 3 years ago

Builds on #46 to try to fix ssize_t issues. There are a couple of things that don't work on Python 3.10, and hopefully this fixes them. Since I don't have a Windows system to test on, I'm depending on CI to tell me if there's a problem.

Rosuav commented 3 years ago

Hmm, I'm not seeing the checks. Is there something that needs to be done to trigger CI?

jd-boyd commented 3 years ago

I'm not sure why they aren't showing. It looks like the AppVeyor config for windows testing stopped working altogether. TravisCI for linux testing ran, but it didn't show the results in this PR. Here is a link to the results: https://travis-ci.org/github/jd-boyd/python-lzo/builds/768711848

Rosuav commented 3 years ago

Hmm. I was hoping to see a Windows build, since that's what I can't do myself, but it WAS building previously, and seemed to have just the one test failure, so hopefully that's all good.

Thanks for merging!

jd-boyd commented 3 years ago

Here is the result of the windows build: https://ci.appveyor.com/project/jd-boyd/python-lzo/builds/38926229
I still will have to look into why they aren't updating correctly on the PRs.

jd-boyd commented 3 years ago

Frankly, most of the time, I don't have a windows setup handy for testing and rely on running test PRs through AppVeyor. I wish I could find an affordable service for MacOS as well.

jd-boyd commented 3 years ago

Again, thank you so much for your contribution. It was extremely refreshing.

Rosuav commented 3 years ago

Ohh, gotcha, cool, thanks. And yeah, it would be awesome if we could all just push code somewhere and have a bunch of eggs built... the PyPA looks into it periodically but it hasn't gone anywhere yet.

Rosuav commented 3 years ago

And, no problem. It scratched an itch :) I keep lots of Python versions around, so it's not THAT big a deal to have to use 3.9 instead of 3.10, but when it's a program that I don't use often, my automatic habit is to type python3 scriptname.py and then it was failing :)