Closed AT0myks closed 1 year ago
Thank you very kindly. I'm still working on processing this, but I very much appreciate the contribution to advance an area that has historically been difficult.
Any update on this? Having the Windows wheels officially provided on PyPI would be nice instead of having to rely on third-party sources, and Windows users installing packages that depend on python-lzo would have one less command to type. The instructions in the readme could also be updated for those who want to build themselves. It still mentions Python 2.7 and the Microsoft link is dead.
Thanks for merging. Could you use the workflow to build the wheels and upload them to PyPI?
I don't expect this to be merged as is but maybe it can help.
This is the workflow I used to build wheels for Windows. In its current state you have to manually run it.
Some modifications could be made to build from the lzo that's included in the repo and to upload the wheels to PyPI on release.
This would close #19, #39, #49 and #55.
Also here are build instructions for Windows that could be added to the readme to close #51:
For
lzo2.lib
:lzo2.lib
and not the wheel)build
directory andcd
into itcmake ..
msbuild lzo_static_lib.vcxproj -p:Configuration=Release;Platform=x64
lzo2.lib
will be in theRelease
directoryFor the wheel:
cd
to the root of the cloned reposet LZO_DIR=C:\path\to\dir
wheredir
containslzo2.lib
pip install -U wheel
python setup.py bdist_wheel
dist
directoryIt would be nice if you could add 1.14 wheels to PyPI for future Windows users and to avoid new issues about installation.
In the meantime wheels can be found here if someone wants them. They were built from lzo 2.10 and the repo in this state, and target CPython for Windows x64.