search

jd-solanki / anu

Anu - DX focused utility based vue component library built on top of UnoCSS & VueUse ⚡️🔥
https://anu-vue.netlify.app/
MIT License
1.03k stars 56 forks source link

Add title property to ATable column so the presented text can be different from the key in the data #206

Closed yooneskh closed 10 months ago

yooneskh commented 11 months ago

Hi, thanks for your great work.

I noticed in the ATable, we cannot have a separate column text than what is the key in the data and this is very limiting. I went ahead and added that to the code, sorry for not discussing it before.

Rigth now the only alternative is to override the slot for each header and render a separate text.

netlify[bot] commented 11 months ago

Deploy Preview for anu-vue ready!

Name Link
Latest commit 4893d0a87bc7786e63fba44b634b9e5e139d7896
Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/64e775ac159a0d0008af27f0
Deploy Preview https://deploy-preview-206--anu-vue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yooneskh commented 10 months ago

Hi.

Is there anything specific in the code stopping this from being merged so i can fix?

yooneskh commented 10 months ago

I added an example to it too.

jd-solanki commented 10 months ago

Hi @yooneskh

Sorry I was busy lately with python. I'll review this soon.

yooneskh commented 10 months ago

@jd-solanki thank you. is it ok if i do other prs too?

jd-solanki commented 10 months ago

Yes, Why not. I just want let you know what I'll be focusing more on python in near future. So, if you would like to maintain this project better, I'm more than happy to get a contributor. I've some great plans for next major version of anu but I don't have enough bandwidth to work fully on it.

yooneskh commented 10 months ago

I love how this project is structured. What has worried me is this issue

https://github.com/jd-solanki/anu/issues/205

If it really be possible to load only the used components and styles, i would love to contribute to this project. Can you please take a look at it?

Thanks

jd-solanki commented 10 months ago

Hi @yooneskh Sorry to say but I have reverted some of the commits which might accidently got into your PR and PR have too many changes. I'm making this fix via separate commit.

yooneskh commented 10 months ago

@jd-solanki thats ok but the example got deleted. Should i make another pr for that?

jd-solanki commented 10 months ago

Oh, sorry for that. Don't worry I'll add it.