search

jdachtera / node-rtpmidi

A node js implementation of Apples Network Midi Protocol.
92 stars 17 forks source link

Local note-off messages are not being transmitted to remote devices #7

Closed ViktorNova closed 10 years ago

ViktorNova commented 10 years ago

To be clear, midi notes generated on the same machine node-rtpmidi is running on are not being transmitted to devices on the other end while using examples/rtpmidi-native-bridge.js (did not test others). The result is an endless pile-up of stuck notes! =o

However, the note-off messages do register on a local midi monitor and the console output (received a local message [ 128, 63, 64 ]), the message just doesn't make it to the other side.

Note-off messages generated on the remote device (iOS in my case) transmit into midi on the local machine just fine

ViktorNova commented 10 years ago

Does anyone else have issue with note-off messages not being transmitted? I'm wondering if this is Linux specific or not

jdachtera commented 10 years ago

Oh I forgot to comment on this issue. Did you try the latest master revision? There were some problems regarding the timestamps with multiple midi commands in a rtpmidi message. This was definitely related to lost note off messages. But these problems should be resolved.

ViktorNova commented 10 years ago

Ok, I just updated fresh and checked again, the stuck notes are still happening consistently, from local machine to iPad

jdachtera commented 10 years ago

The problem is I don't have an iDevice to check. The simulator does not have the app store so one can only use self compiled open source apps with it. Did you run "npm update" after pulling the latest changes? There was also an error in the midi-common dependency where the dataLength of noteOff commands was set to 1 instead of 2.

ViktorNova commented 10 years ago

Aha, that was it! It works perfectly now, and is actually very stable. You rock, thank you again!

jdachtera commented 10 years ago

Great, thanks!