search

jdaehne / BackupMODX

Tiny Backup Widget for MODX-Sites
17 stars 11 forks source link

function close() #33

Closed ryube801960 closed 5 years ago

ryube801960 commented 5 years ago

I always get the error message "Uncaught Error: Call to a member function close()" when I try to backup files, but fine with database.

dev7apps commented 5 years ago

Same issue here. Uninstalled and reinstalled. No luck. Enabled debugging, but nothing logged. DB backup alone is fine.

Full Error:

Uncaught Error: Call to a member function close() on string in /pathtocore/core/components/backupmodx/vendor/chumper/zipper/src/Chumper/Zipper/Zipper.php:67 
Stack trace: 
#0 /pathtocore/core/components/backupmodx/src/Backup/Backup.php(114): Chumper\Zipper\Zipper->__destruct() 
#1 /pathtocore/core/components/backupmodx/src/Backup/Backup.php(222): BackupMODX\Backup\Backup->backupFiles('2019-08-08--185...') 
#2 /pathtocore/core/components/backupmodx/processors/backup.class.php(42): BackupMODX\Backup\Backup->backup(true, false, '') 
#3 /pathtocore/model/modx/modprocessor.class.php(177): BackupMODXBackupProcessor->process() 
#4 /pathtocore/core/model/modx/modx.class.php(1764): modProcessor->run() 
#5 /pathtocore/core/model/modx/modconnectorresponse.class.php(144): modX->runProcessor('backup', Array, Array) 
#6 /pathtocore/core/model/modx/modconnectorrequest.class.php(86): modConnectorResponse->outputContent(Array) 
#7 /pathtocore/core/model/modx/modconnec

MODX Revolution 2.7.1-pl Ubuntu 16 Php 7

des-yogi commented 5 years ago

I have a similar error! MODX Revolution 2.7.1-pl Ubuntu 16 Php 7.1 Older versions worked fine on this server

Jako commented 5 years ago

I am not sure whats going wrong there. Please look into the backupmodx.targetPath system setting. Does it point to {core_path}backup/ or elsewhere? Is that target a folder and is it writable?

There should be a backupmodx.log in core/cache/logs if you enable the debug option. Is the target folder included in the file list?

Jako commented 5 years ago

You could add the following patch to log the target in core/cache/logs/backupmodx.log

https://github.com/jdaehne/BackupMODX/commit/504ec092b26fd2a531713088a551461e88e47b84

rharrell-southern commented 5 years ago

I can confirm this is still an issue, I'm on MODX Revolution 2.7.1-pl PHP Version 7.2.19

Backup config path is default, I just did a wipe and clean install on BackupMODX. Sql backs up fine, but the process that zips up the system files seems to be failing, with the error message listed above. After the job fails I can see the folder for the job, as well as the sql file, but no zip file in the output directory. Seems like it might be an error in the Chumper script, or possibly an error in how it is called?

rharrell-southern commented 5 years ago

Ahh, got it figured out. You need the library PHP-zip installed. In Ubuntu, just do:

sudo apt-get install php-zip

Here's the reference from Chumper's github issue tracker where I found the solution: https://github.com/Chumper/Zipper/issues/103

Jako commented 5 years ago

This execption was not catched. It should be catched with https://github.com/jdaehne/BackupMODX/pull/41/commits/e80ee9ea9e97ac385a1f63af8d7aa962ebd74f99