search

jdah / jdh-8

An 8-bit minicomputer with a fully custom architecture
MIT License
1.29k stars 89 forks source link

Minor circuit reconfigurations #22

Closed kernelwernel closed 2 years ago

kernelwernel commented 2 years ago

Closed unnecessary ports on splitters, applied some wire savings and added some miscellaneous visual simplifications. I'm certain the changes shouldn't cause any unexpected behaviour and the circuit should work perfectly.

Logisim's custom HDL (or any HDL for that matter) isn't exactly easy to analyse at first glance so I'll just add some before and after images of my PR to not complicate things.

BEFORE:

  1. https://cdn.discordapp.com/attachments/816669196565741629/881958499498741780/unknown.png
  2. https://cdn.discordapp.com/attachments/816669196565741629/881958725689155624/unknown.png
  3. https://cdn.discordapp.com/attachments/816669196565741629/881960593668579358/unknown.png

AFTER:

  1. https://cdn.discordapp.com/attachments/816669196565741629/881958263539793930/unknown.png
  2. https://cdn.discordapp.com/attachments/816669196565741629/881958774619930714/unknown.png
  3. https://cdn.discordapp.com/attachments/816669196565741629/881959271405858816/unknown.png

btw, I absolutely love your videos. Good luck with building the rest of the components for your custom computer :)

jdah commented 2 years ago

Thanks for the contribution :) the circuits have changed enough on my end (and will be updated soon), so I won't include these changes, but I appreciate the contribution a lot. An important part of this repo is that while the project is under active development a lot of the circuit stuff is (very) temporary.

kernelwernel commented 2 years ago

ah i see, my bad