jdah / jdh-8

An 8-bit minicomputer with a fully custom architecture
MIT License
1.29k stars 89 forks source link

Inconsistency in the specification #36

Closed TediusTimmy closed 2 years ago

TediusTimmy commented 2 years ago

Firstly, you state in README.md and SPEC.txt that: E: CMP* reg, imm8/reg -> reg = reg + imm8/reg However, the line in libemu.c that implements it is: case I_CMP: r = a; break; I get that the purpose of the instruction is to load the flags register as if the operation had taken place. But, then the spec says that the operation does happen.

jdah commented 2 years ago

Fixed in 67a53b6aecc386eccb9038a9fec12e4097bb8c25 :-)