Build files are missing in published versions

jdalrymple / gitbeaker

🦊🧪 A comprehensive and typed Gitlab SDK for Node.js, Browsers, Deno and CLI

Other

1.55k stars 295 forks source link

Build files are missing in published versions #3521

Closed kaufmo closed 8 months ago

kaufmo commented 8 months ago

Description

Node.js version: 20.9.0
Gitbeaker version: 39.33.2
Gitbeaker release (cli, rest, core, requester-utils): all
OS & version: Ubuntu 23.10

Steps to reproduce

install newest version and use it

Possible fixes

add missing builded source code to the published packages

Checklist

[x] I have checked that this is not a duplicate issue.
[x] I have read the documentation.

nejch commented 8 months ago

I'm guessing something in https://github.com/jdalrymple/gitbeaker/commit/f277995994829138a7fb67358c312d5f485713ee broke this as the previous versions still had the code on npmjs (39.33.0).

kaufmo commented 8 months ago

I'm guessing something in f277995 broke this as the previous versions still had the code on npmjs (39.33.0).

yes I think the build is missing for the release pipeline

jet-esavichev commented 8 months ago

+1 for this issue. Had to rollback the version as it broke our workflow.

Delagen commented 8 months ago

Also I think that packages should be strictly versioned for dependencies, i.e. without ^. Because when installing certain version of @gitbeacker/rest - dependent @gitbeaker/* packages can be newer packages, so may be incompatible or broken.

jet-esavichev commented 8 months ago

Also I think that packages should be strictly versioned for dependencies, i.e. without ^. Because when installing certain version of @gitbeacker/rest - dependent @gitbeaker/* packages can be newer packages, so may be incompatible or broken.

That's what I did as a workaround. And agree, it's a good practice for production.

The issue appeared on 39.33.1 Versions 39.33.0 and before are OK.