Open pvignau opened 4 months ago
AFAIK, the problem is not on the package side but on gitlab. If the POST request is made with query params, it works ...
axios.post(
`https://FQDN/api/v4/projects/${PROJECT_ID}/merge_requests/${CI_MERGE_REQUEST_IID}/notes?body=${encodeURIComponent(comment)}`,
{},
config
)
is ok ..
Question answered 🤷♂️, closing the issue, sorry for the spam
Darn, this is the library. In the library i assume the POST request is sending a body and not via query params. Ill fix this
The docs make no indication of this though -_-
POST /projects/:id/merge_requests/:merge_request_iid/notes
Ill file an issue with GL to figure out what should be happening here.
Cheers mate, thanks for the quick answer !
The docs make no indication of this though -_-
POST /projects/:id/merge_requests/:merge_request_iid/notes
I found it on the PUT request doc : https://archives.docs.gitlab.com/16.5/ee/api/notes.html#modify-existing-merge-request-note
Yea, there are definitely some inconsistencies. The example request for the modify call has it as a query param, but the upper docs make no indication that it should be a query param
Description
Hey there, I don't know why but I can't create a note in a merge request. I know that the package suports Gitlab to its 16.5 version and I'm under 17 but the API does not seem to be different. https://docs.gitlab.com/ee/api/notes.html#create-new-merge-request-note https://archives.docs.gitlab.com/16.5/ee/api/notes.html#create-new-merge-request-note
I don't know if this is a bug of the package or the gitlab server. Am I the only one to experience this ? Thanks for your help !
Steps to reproduce
Expected behaviour
If
targetNote
is undefined a new one is created.Actual behaviour
I have a Bad Request returned from the server
Checklist