search

jdamata / terraform-provider-sonarqube

Terraform provider for managing Sonarqube configuration
GNU General Public License v3.0
62 stars 54 forks source link

Add expirationDate parameter to user_token #112

Closed fhusson closed 1 year ago

fhusson commented 1 year ago

Hi, this Pull Request is to add the ExpirationDate parameter to the user_token ressource.

113

Be carefull, I have not tested the code.

jdamata commented 1 year ago

Do you mind adding an acceptance test for this? It should be pretty simple. https://github.com/jdamata/terraform-provider-sonarqube/blob/master/sonarqube/resource_sonarqube_user_token_test.go

fhusson commented 1 year ago

Do you mind adding an acceptance test for this? It should be pretty simple. https://github.com/jdamata/terraform-provider-sonarqube/blob/master/sonarqube/resource_sonarqube_user_token_test.go

Hi sorry it's done, sorry for the delay.

jdamata commented 1 year ago

Do you mind adding an acceptance test for this? It should be pretty simple. https://github.com/jdamata/terraform-provider-sonarqube/blob/master/sonarqube/resource_sonarqube_user_token_test.go

Hi sorry it's done, sorry for the delay.

Thanks!! Just 1 modification to the test case and we should be good to go