Closed ViktorLindgren95 closed 1 year ago
Oh ok , i thought it was specifically enterprise . My bad 😊
On Thu, Feb 2, 2023, 18:03 jwilliams-fn @.***> wrote:
@.**** commented on this pull request.
In Makefile https://github.com/jdamata/terraform-provider-sonarqube/pull/119#discussion_r1094818244 :
@@ -1,7 +1,7 @@ export GO111MODULE=on export TF_LOG=DEBUG SRC=$(shell find . -name '*.go') -SONARQUBE_IMAGE?=sonarqube:latest +SONARQUBE_IMAGE?=sonarqube:enterprise
alm_settings APIs only require the developer or greater sonarqube.
— Reply to this email directly, view it on GitHub https://github.com/jdamata/terraform-provider-sonarqube/pull/119#pullrequestreview-1281484757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRJY4C73CMVH3Z5XVCK67TWVPSEZANCNFSM6AAAAAAUO7MQCE . You are receiving this because you authored the thread.Message ID: @.*** com>
tests are failing because we also need to update github pipelines to use sonarqube:developer image. Can you also do this please :)
tests are failing because we also need to update github pipelines to use sonarqube:developer image. Can you also do this please :)
Updated the both tests. I also changed the tag specifically for the developer one to LTS dynamic, I Can change it back to specific 8.9 if you so desire, they are the same for now
Local testing has hit a snag because sonarqube changed LTS to 9.9 over night
If you wonder about the results seem like a lot of auth stuff is missing in some of the tests
@jdamata Ready for review 👍
Thank you for the contribution. Ill cut a new release in a few minutes so folks can start using the new resources
( I notice that the stuff from my other PR is in here aswell)
Added two functionalities
GitHub ALM
Added the ability to add a Github ALM / Devops Platform Integration to your sonarqube instance This comes with both documentation and testing which, including a live integration test on my local environment Importing isnt supported right now, I will hopefully add this over the comming days if i have the spare time
GitHub Binding
Added the ability to add a relation between your Sonarqube project and your GitHub repository This comes with both documentation and testing which, including a live integration test on my local environment Importing isnt supported right now, I will hopefully add this over the comming days if i have the spare time
Breaking change
ALM settings require sonarqube enterprise version, therefor i have changed the testing image to enterprise. It still works to do tests like we have been doing with an enterprise image aswell