search

jdamata / terraform-provider-sonarqube

Terraform provider for managing Sonarqube configuration
GNU General Public License v3.0
62 stars 54 forks source link

Hotfix : Github Binding #123

Closed ViktorLindgren95 closed 1 year ago

ViktorLindgren95 commented 1 year ago

I found a bug in the GitHub binding where if you use a full name with the structure such as "jdamata/terraform-provider-sonarqube" , the id would be project/jdamata/terraform-provider-sonarqube , but because we split on / it would be three strings which causes the project to fail. Ive corrected this and also added a test inside the github binding to test org/testAccSonarqubeGithubBindingName so that we can support full name structure

ViktorLindgren95 commented 1 year ago

@jdamata (cant add reviewer so im tagging )

ViktorLindgren95 commented 1 year ago

Thank you for quick response