search

jdamata / terraform-provider-sonarqube

Terraform provider for managing Sonarqube configuration
GNU General Public License v3.0
62 stars 54 forks source link

Update the sonarqube_user_token resource for the latest APIs #125

Closed jwilliams-fn closed 1 year ago

jwilliams-fn commented 1 year ago

This is an update to the sonarqube_user_token resource, specifically to support #89, but this also matches the latest version of the API (e.g.: login_name is now optional, etc).

This is my first time writing any Go code, so feel free to be as nit-picky as you wish. I did write tests, but was unable to get the make -i testacc command to work locally. make does build just fine though.

jwilliams-fn commented 1 year ago

@jdamata I'd love to work through this with you when you have the time. (Apologies for the ping, I'm sure you're busy and this is a hobby more than anything, but I'd rather use this existing terraform provider rather than hack together my own)

jdamata commented 1 year ago

@jdamata I'd love to work through this with you when you have the time. (Apologies for the ping, I'm sure you're busy and this is a hobby more than anything, but I'd rather use this existing terraform provider rather than hack together my own)

Sorry about that. Busy couple of weeks. I've enabled builds on this PR so that acceptance tests are running on commits. You've got some test issues that need sorting.

jwilliams-fn commented 1 year ago

@jdamata I believe I fixed the test failures (at least locally), but since this API was not updated until 9.5, I fear the tests may fail in your GitHub Actions until the sonarqube image being used is updated.

jwilliams-fn commented 1 year ago

@jdamata I believe I fixed the test failures (at least locally), but since this API was not updated until 9.5, I fear the tests may fail in your GitHub Actions until the sonarqube image being used is updated.

Oh goody the tests all passed here!

jdamata commented 1 year ago

Thanks for the contribution!! I'll cut a release soon so that folks can start using this. There are a few more PRs open so i might see if we can get those merged as well before a new version is cut