Support Sonarqube portfolios

[felixlut]

This PR introduces support for Portolios. Worth to note are the following:

• I have not implemented the option for MANUAL portfolios to add projects via terraform
  • This PR is big as is. I'd rather do it later in that case. I'll work on it when I get the time if you want that functionality in this PR though
• func validatePortfolioResource
  • I implemented this as a validator for REGEXP and TAGS portfolios so that we don't end up in Terraform limbo, where the portfolio is created, but setting the mode fails. There might be cleaner ways of solving it, but I think it's fine
  • This function is called in the beginning of the Create and Update calls
• For some unholy reason only sonarqube:enterprise have support for portfolios. I'll let you @jdamata decide how you wanna handle CI for this. I don't know if it would be against their license modle to use the enterprise image for testing purposes
  • Proof that it works on enterprise image

Resolves #140

[jdamata]

This is elegantly written and i appreciate you keeping the PR on the smaller side for me to review.

As for the sonarqube:enterprise I spent a fair amount of time poking around to see if it would be an issue for us to use this version of sonarqube but couldn't find anything. Im trying to reach out to their support to see if they would have a problem with it. I think we should go ahead and update the CI to the enterprise docker version and get the tests in a passing. I can always revert the CI change and figure out what to do later if I hear back from sonarsource

[felixlut]

I could implement something like whats done here, to make the tests only run against enterprise editions. Ì looked into it a bit, the system/info endpoint exposes which edition is running (enterprise/developer/community). And the same for the resoruce file here.

The edition could be exposed in the same way the sonarQubeVersion is.

Then the tests can be run on multiple editions with something like this.

[jdamata]

I could implement something like whats done here, to make the tests only run against enterprise editions. Ì looked into it a bit, the system/info endpoint exposes which edition is running (enterprise/developer/community). And the same for the resoruce file here.

The edition could be exposed in the same way the sonarQubeVersion is.

Then the tests can be run on multiple editions with something like this.

This is something the provider does not do currently. I am positive there are existing resources/tests already in this provider that wont work with all versions of sonarqube. (IE: https://github.com/jdamata/terraform-provider-sonarqube/issues/137)

I think this is a great idea. Inevitably when users of this provider run into issues with this resource, being able to return a helpful error of only supported in enterprise edition is going to save me and the user some time.

It would probably make sense to do this in another PR? Otherwise when you change the CI, you'll get stuck trying to fix other resources that are not compatible with a specific version of sonarqube

[felixlut]

I could implement something like whats done here, to make the tests only run against enterprise editions. Ì looked into it a bit, the system/info endpoint exposes which edition is running (enterprise/developer/community). And the same for the resoruce file here. The edition could be exposed in the same way the sonarQubeVersion is. Then the tests can be run on multiple editions with something like this.

This is something the provider does not do currently. I am positive there are existing resources/tests already in this provider that wont work with all versions of sonarqube. (IE: #137)

I think this is a great idea. Inevitably when users of this provider run into issues with this resource, being able to return a helpful error of only supported in enterprise edition is going to save me and the user some time.

It would probably make sense to do this in another PR? Otherwise when you change the CI, you'll get stuck trying to fix other resources that are not compatible with a specific version of sonarqube

Agreed. I've changed the CI on this PR to use the enterprise image. I can look into adding a PR changing the CI to use multiple images.

So basically, the second CI will do the following:

• Change the CI to run against the following images
  • enterprise
  • developer
  • community
• Fix any issues that shows up as a part of that (crossing my fingers there aren't that many 🤞).
  • Basically adding error messages for whatever pops up that are ran depending on the version and edition of SonarQube is running
  • Known issues right now will be:
    • Portfolio only working in enterprise
    • GitLab Binding not working on community #137