search

jdamata / terraform-provider-sonarqube

Terraform provider for managing Sonarqube configuration
GNU General Public License v3.0
62 stars 54 forks source link

Update CI to test provider against the 3 different editions of SonarQube #144

Closed felixlut closed 1 year ago

felixlut commented 1 year ago

This PR is in draft mode until #143 is merged. Once it is, I will rebase this PR on top of that, and re-write this PR description.

github-advanced-security[bot] commented 1 year ago

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

jdamata commented 1 year ago

Did you think it doesn't make sense to have tests running against latest images as well as the current LTS version? Curious why you removed it

felixlut commented 1 year ago

Did you think it doesn't make sense to have tests running against latest images as well as the current LTS version? Curious why you removed it

The lts and community tags are pointing to the same image: https://hub.docker.com/_/sonarqube Screenshot_20230328-071545.png

felixlut commented 1 year ago

I could change the images to lts-{edition} if that is clearer.

Also, i have no idea what the 2 datacenter editions are so i skipped running tests against them. Do you know what they are, and if it would be a good idea to add them to the CI?

jdamata commented 1 year ago

I could change the images to lts-{edition} if that is clearer.

Also, i have no idea what the 2 datacenter editions are so i skipped running tests against them. Do you know what they are, and if it would be a good idea to add them to the CI?

had no idea latest and lts were the same. i think we are fine as is

datacenter is similar to enterprise and probably the same on the api side of things. Datacenter focuses on scalability and resiliency. I dont think we need it here.

Thanks for your work on this